data-collector-mcp/data_collector_mcp/collector_api.py

from __future__ import annotations

from typing import Any

from .auth import find_project_config, resolve_project_token
from .http_client import request_json
from .protocols import BACNET_SPEC, MODBUS_SPEC, S7_SPEC
from .protocols.bacnet import normalize_bacnet_object_type
from .protocols.modbus import MODBUS_POINT_TYPE_ALIASES, MODBUS_REGISTER_TYPE_ALIASES
from .protocols.s7 import S7_POINT_TYPE_ALIASES, S7_REGISTER_TYPE_ALIASES


BACNET_OBJECT_ID_MAX = 4_194_303


def _merge_defaults(defaults: dict[str, Any], payload: dict[str, Any]) -> dict[str, Any]:
    merged = dict(defaults)
    merged.update(payload)
    return merged


def _success_response(response: dict[str, Any]) -> bool:
    return response.get("state") == 0


def _require_non_empty_text(payload: dict[str, Any], field_name: str) -> str:
    value = str(payload.get(field_name) or "").strip()
    if not value:
        raise ValueError(f"payload.{field_name} is required")
    return value


def _require_present(payload: dict[str, Any], field_name: str) -> Any:
    if field_name not in payload or payload.get(field_name) is None:
        raise ValueError(f"payload.{field_name} is required")
    return payload[field_name]


def _normalize_modbus_device_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = dict(payload)

    normalized["name"] = _require_non_empty_text(normalized, "name")
    normalized["ip"] = _require_non_empty_text(normalized, "ip")
    _require_present(normalized, "device_type")
    _require_present(normalized, "port")
    _require_present(normalized, "slave_id")
    _require_present(normalized, "word_order")
    _require_present(normalized, "byte_order")
    address_base = _require_present(normalized, "address_base")
    normalized["address_offset"] = address_base
    normalized.pop("address_base", None)

    return normalized


def _normalize_modbus_device_edit_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = dict(payload)

    normalized["ori_id"] = _normalize_positive_int(_require_present(normalized, "ori_id"), "payload.ori_id")
    normalized["name"] = _require_non_empty_text(normalized, "name")

    if normalized.get("type") is None:
        normalized["type"] = _require_present(normalized, "device_type")
    try:
        normalized["type"] = int(normalized["type"])
    except Exception as exc:
        raise ValueError("payload.type must be one of 1, 2, 3, 4, 5") from exc
    if normalized["type"] not in {1, 2, 3, 4, 5}:
        raise ValueError("payload.type must be one of 1, 2, 3, 4, 5")
    normalized.pop("device_type", None)

    if normalized["type"] == 2:
        normalized["serial_port"] = _require_non_empty_text(normalized, "serial_port")
    else:
        normalized["ip"] = _require_non_empty_text(normalized, "ip")
        _require_present(normalized, "port")

    _require_present(normalized, "slave_id")
    _require_present(normalized, "word_order")
    _require_present(normalized, "byte_order")

    if "address_base" in normalized:
        normalized["address_offset"] = normalized["address_base"]
        normalized.pop("address_base", None)
    if "group_id" in normalized and "device_group_id" not in normalized:
        normalized["device_group_id"] = normalized["group_id"]
        normalized.pop("group_id", None)

    return normalized


def _normalize_modbus_point_payload(payload: dict[str, Any], *, require_device_id: bool = True) -> dict[str, Any]:
    normalized = dict(payload)

    normalized["name"] = _require_non_empty_text(normalized, "name")
    _require_present(normalized, "address")
    if require_device_id:
        normalized["device_id"] = _normalize_positive_int(
            _require_present(normalized, "device_id"),
            "payload.device_id",
        )

    raw_type = _require_non_empty_text(normalized, "type")
    normalized_type = MODBUS_POINT_TYPE_ALIASES.get(raw_type)
    if normalized_type is None:
        normalized_type = MODBUS_POINT_TYPE_ALIASES.get(raw_type.lower())
    if normalized_type is None:
        raise ValueError(
            "payload.type is invalid; use one of bool, int16, uint16, int32, "
            "uint32, int64, uint64, float32, float64, or a documented alias "
            "such as SHORT, WORD, LONG, DWORD, FLOAT, DOUBLE"
        )
    normalized["type"] = normalized_type

    if normalized.get("func_code") is None:
        register_type = _require_non_empty_text(normalized, "register_type")
        func_code = MODBUS_REGISTER_TYPE_ALIASES.get(register_type)
        if func_code is None:
            func_code = MODBUS_REGISTER_TYPE_ALIASES.get(register_type.lower())
        if func_code is None:
            raise ValueError(
                "payload.register_type is invalid; use coil, discrete_input, "
                "holding_register, input_register, or func_code 1/2/3/4"
            )
        normalized["func_code"] = func_code
    else:
        try:
            normalized["func_code"] = int(str(normalized["func_code"]).strip())
        except Exception as exc:
            raise ValueError("payload.func_code must be one of 1, 2, 3, 4") from exc
        if normalized["func_code"] not in {1, 2, 3, 4}:
            raise ValueError("payload.func_code must be one of 1, 2, 3, 4")

    if "register_type" in normalized:
        normalized.pop("register_type")

    return normalized


def _normalize_modbus_point_edit_payload(payload: dict[str, Any]) -> dict[str, Any]:
    _require_present(payload, "ori_id")
    normalized = _normalize_modbus_point_payload(payload, require_device_id=False)
    normalized["ori_id"] = _normalize_positive_int(_require_present(normalized, "ori_id"), "payload.ori_id")
    return normalized


def _normalize_s7_device_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = dict(payload)

    normalized["name"] = _require_non_empty_text(normalized, "name")
    normalized["ip"] = _require_non_empty_text(normalized, "ip")
    _require_present(normalized, "rock")
    _require_present(normalized, "slot")
    if "group_id" in normalized and "device_group_id" not in normalized:
        normalized["device_group_id"] = normalized["group_id"]
        normalized.pop("group_id", None)
    if "tsap_conn_type" in normalized and normalized["tsap_conn_type"] is not None:
        normalized["tsap_conn_type"] = _normalize_s7_tsap_conn_type(normalized["tsap_conn_type"])
    else:
        normalized["tsap_conn_type"] = "PG"

    return normalized


def _normalize_s7_device_edit_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = _normalize_s7_device_payload(payload)
    if normalized.get("id") is None:
        normalized["id"] = _require_present(normalized, "ori_id")
    normalized["id"] = _normalize_positive_int(normalized["id"], "payload.id")
    normalized.pop("ori_id", None)
    return normalized


def _normalize_s7_point_payload(payload: dict[str, Any], *, require_device_id: bool = True) -> dict[str, Any]:
    normalized = dict(payload)

    normalized["name"] = _require_non_empty_text(normalized, "name")
    normalized["address"] = _require_non_empty_text(normalized, "address")
    if require_device_id:
        normalized["device_id"] = _normalize_positive_int(
            _require_present(normalized, "device_id"),
            "payload.device_id",
        )

    raw_type = normalized.get("data_type")
    if raw_type is None:
        raw_type = _require_non_empty_text(normalized, "type")
    else:
        raw_type = str(raw_type).strip()
        if not raw_type:
            raise ValueError("payload.data_type is required")
    normalized_type = S7_POINT_TYPE_ALIASES.get(raw_type)
    if normalized_type is None:
        normalized_type = S7_POINT_TYPE_ALIASES.get(raw_type.lower())
    if normalized_type is None:
        raise ValueError(
            "payload.data_type is invalid; use one of bool, uint8, int8, "
            "uint16, int16, uint32, int32, float32, float64, or a documented "
            "alias such as BOOL, BYTE, SINT, WORD, INT, DWORD, DINT, REAL, LREAL"
        )
    normalized["data_type"] = normalized_type
    normalized.pop("type", None)

    if normalized.get("register_type") is None:
        register_area = _require_non_empty_text(normalized, "register_area")
        register_type = S7_REGISTER_TYPE_ALIASES.get(register_area)
        if register_type is None:
            register_type = S7_REGISTER_TYPE_ALIASES.get(register_area.lower())
        if register_type is None:
            raise ValueError("payload.register_area is invalid; use I, Q, M, DB, V, AI, or register_type 1..6")
        normalized["register_type"] = register_type
    else:
        try:
            normalized["register_type"] = int(str(normalized["register_type"]).strip())
        except Exception as exc:
            raise ValueError("payload.register_type must be one of 1, 2, 3, 4, 5, 6") from exc
        if normalized["register_type"] not in {1, 2, 3, 4, 5, 6}:
            raise ValueError("payload.register_type must be one of 1, 2, 3, 4, 5, 6")
    normalized.pop("register_area", None)

    if "group_id" in normalized and "group_Id" not in normalized:
        normalized["group_Id"] = normalized["group_id"]
        normalized.pop("group_id", None)

    return normalized


def _normalize_s7_point_edit_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = _normalize_s7_point_payload(payload)
    if normalized.get("id") is None:
        normalized["id"] = _require_present(normalized, "ori_id")
    normalized["id"] = _normalize_positive_int(normalized["id"], "payload.id")
    normalized.pop("ori_id", None)
    return normalized


def _normalize_bacnet_device_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = dict(payload)

    normalized["name"] = _require_non_empty_text(normalized, "name")
    normalized["ip"] = _require_non_empty_text(normalized, "ip")
    normalized["bacnet_device_id"] = _normalize_bacnet_id(
        _require_present(normalized, "bacnet_device_id"),
        "payload.bacnet_device_id",
    )
    normalized["device_type"] = 1
    normalized["type"] = "bacnet"

    if "device_id" in normalized:
        normalized.pop("device_id", None)
    if "device_group_id" in normalized and "group_id" not in normalized:
        normalized["group_id"] = normalized["device_group_id"]
    normalized.pop("device_group_id", None)
    if "bacnet_net" in normalized:
        normalized["bacnet_net"] = _normalize_non_negative_int(normalized["bacnet_net"], "payload.bacnet_net")
    elif "net" in normalized:
        normalized["bacnet_net"] = _normalize_non_negative_int(normalized["net"], "payload.net")
    normalized.pop("net", None)

    return normalized


def _normalize_bacnet_device_edit_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = dict(payload)
    normalized["ori_id"] = _normalize_positive_int(_require_present(normalized, "ori_id"), "payload.ori_id")
    normalized["name"] = _require_non_empty_text(normalized, "name")
    normalized["ip"] = _require_non_empty_text(normalized, "ip")
    bacnet_device_id = _normalize_bacnet_id(
        _require_present(normalized, "bacnet_device_id"),
        "payload.bacnet_device_id",
    )
    normalized["device_id"] = str(bacnet_device_id)
    normalized["type"] = 1
    normalized.pop("bacnet_device_id", None)
    normalized.pop("device_type", None)

    if "group_id" in normalized and "device_group_id" not in normalized:
        normalized["device_group_id"] = normalized["group_id"]
    normalized.pop("group_id", None)
    if "bacnet_net" in normalized:
        normalized["net"] = _normalize_non_negative_int(normalized["bacnet_net"], "payload.bacnet_net")
    elif "net" in normalized:
        normalized["net"] = _normalize_non_negative_int(normalized["net"], "payload.net")
    normalized.pop("bacnet_net", None)

    return normalized


def _normalize_bacnet_point_payload(payload: dict[str, Any], *, require_device_id: bool = True) -> dict[str, Any]:
    normalized = dict(payload)

    if require_device_id:
        normalized["device_id"] = _normalize_positive_int(
            _require_present(normalized, "device_id"),
            "payload.device_id",
        )
    normalized["object_type"] = normalize_bacnet_object_type(_require_non_empty_text(normalized, "object_type"))
    normalized["object_id"] = _normalize_bacnet_id(_require_present(normalized, "object_id"), "payload.object_id")
    object_name = str(normalized.get("object_name") or normalized.get("name") or "").strip()
    if not object_name:
        raise ValueError("payload.object_name is required")
    normalized["object_name"] = object_name
    normalized["name"] = str(normalized.get("name") or object_name).strip() or object_name

    if normalized.get("priority") is not None:
        normalized["priority"] = _normalize_positive_int(normalized["priority"], "payload.priority")

    return normalized


def _normalize_bacnet_point_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = _merge_defaults(
        BACNET_SPEC.point_defaults,
        _normalize_bacnet_point_payload(payload),
    )
    device_id = normalized.pop("device_id")
    normalized.pop("invalid_values", None)
    normalized.pop("valid_range_start", None)
    normalized.pop("valid_range_end", None)
    return {"device_id": device_id, "points": [normalized]}


def _normalize_bacnet_point_edit_payload(payload: dict[str, Any]) -> dict[str, Any]:
    normalized = _merge_defaults(
        BACNET_SPEC.point_defaults,
        _normalize_bacnet_point_payload(payload, require_device_id=False),
    )
    normalized["id"] = _normalize_positive_int(_require_present(normalized, "ori_id"), "payload.ori_id")
    normalized.pop("ori_id", None)
    normalized.pop("device_id", None)
    return normalized


def _request_collector(
    project_key: str,
    method: str,
    path: str,
    *,
    json_payload: dict[str, Any] | None = None,
) -> dict[str, Any]:
    project = find_project_config(project_key)
    authorization = resolve_project_token(project)
    response_payload = request_json(
        method,
        f"{project['data_collector_base_url']}{path}",
        authorization,
        json_payload=json_payload,
    )
    if not isinstance(response_payload, dict):
        raise ValueError(f"collector API returned invalid payload for {path}: {response_payload}")
    return response_payload


def _build_modbus_device_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    return _merge_defaults(
        MODBUS_SPEC.device_defaults,
        _normalize_modbus_device_payload(payload),
    )


def _build_modbus_point_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    return _merge_defaults(
        MODBUS_SPEC.point_defaults,
        _normalize_modbus_point_payload(payload),
    )


def _build_s7_device_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    return _merge_defaults(
        S7_SPEC.device_defaults,
        _normalize_s7_device_payload(payload),
    )


def _build_s7_point_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    return _merge_defaults(
        S7_SPEC.point_defaults,
        _normalize_s7_point_payload(payload),
    )


def _build_bacnet_device_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    return _merge_defaults(
        BACNET_SPEC.device_defaults,
        _normalize_bacnet_device_payload(payload),
    )


def _build_bacnet_point_create_payload(payload: dict[str, Any]) -> dict[str, Any]:
    return _normalize_bacnet_point_create_payload(payload)


def create_modbus_device(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        MODBUS_SPEC.create_device_path,
        json_payload=_build_modbus_device_create_payload(payload),
    )


def create_modbus_point(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        MODBUS_SPEC.create_point_path,
        json_payload=_build_modbus_point_create_payload(payload),
    )


def create_s7_device(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        S7_SPEC.create_device_path,
        json_payload=_build_s7_device_create_payload(payload),
    )


def create_s7_point(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        S7_SPEC.create_point_path,
        json_payload=_build_s7_point_create_payload(payload),
    )


def create_bacnet_device(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        BACNET_SPEC.create_device_path,
        json_payload=_build_bacnet_device_create_payload(payload),
    )


def create_bacnet_point(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        BACNET_SPEC.create_point_path,
        json_payload=_build_bacnet_point_create_payload(payload),
    )


def create_modbus_devices(project_key: str, devices: list[dict[str, Any]]) -> dict[str, Any]:
    return _create_devices_batch(
        project_key,
        devices,
        create_path=MODBUS_SPEC.create_device_path,
        build_payload=_build_modbus_device_create_payload,
        match_device=_match_modbus_device,
    )


def create_modbus_points(project_key: str, points: list[dict[str, Any]]) -> dict[str, Any]:
    return _create_points_batch(
        project_key,
        points,
        create_path=MODBUS_SPEC.create_point_path,
        build_payload=_build_modbus_point_create_payload,
    )


def create_s7_devices(project_key: str, devices: list[dict[str, Any]]) -> dict[str, Any]:
    return _create_devices_batch(
        project_key,
        devices,
        create_path=S7_SPEC.create_device_path,
        build_payload=_build_s7_device_create_payload,
        match_device=_match_s7_device,
    )


def create_s7_points(project_key: str, points: list[dict[str, Any]]) -> dict[str, Any]:
    return _create_points_batch(
        project_key,
        points,
        create_path=S7_SPEC.create_point_path,
        build_payload=_build_s7_point_create_payload,
    )


def create_bacnet_devices(project_key: str, devices: list[dict[str, Any]]) -> dict[str, Any]:
    return _create_devices_batch(
        project_key,
        devices,
        create_path=BACNET_SPEC.create_device_path,
        build_payload=_build_bacnet_device_create_payload,
        match_device=_match_bacnet_device,
    )


def create_bacnet_points(project_key: str, points: list[dict[str, Any]]) -> dict[str, Any]:
    return _create_points_batch(
        project_key,
        points,
        create_path=BACNET_SPEC.create_point_path,
        build_payload=_build_bacnet_point_create_payload,
    )


def _create_devices_batch(
    project_key: str,
    devices: list[dict[str, Any]],
    *,
    create_path: str,
    build_payload: Any,
    match_device: Any,
) -> dict[str, Any]:
    results: list[dict[str, Any]] = []
    errors: list[dict[str, Any]] = []
    created: list[tuple[dict[str, Any], dict[str, Any]]] = []

    for index, item in enumerate(devices):
        if not isinstance(item, dict):
            errors.append({"index": index, "stage": "create_device", "error": "device item must be an object"})
            continue

        result: dict[str, Any] = {
            "index": index,
            "name": item.get("name"),
            "device_id": None,
            "create_response": None,
            "matched_device": None,
        }
        results.append(result)

        try:
            request_payload = build_payload(item)
            response = _request_collector(project_key, "POST", create_path, json_payload=request_payload)
        except Exception as exc:
            errors.append({"index": index, "name": item.get("name"), "stage": "create_device", "error": str(exc)})
            continue

        result["create_response"] = response
        if _success_response(response):
            created.append((request_payload, result))
        else:
            errors.append(
                {
                    "index": index,
                    "name": item.get("name"),
                    "stage": "create_device",
                    "error": response.get("state_info") or response.get("msg") or str(response),
                }
            )

    if created:
        try:
            device_list = list_devices(project_key, num_points=False)
            flattened_devices = _flatten_device_tree(device_list.get("devices", []))
        except Exception as exc:
            for _, result in created:
                errors.append(
                    {
                        "index": result["index"],
                        "name": result.get("name"),
                        "stage": "match_device",
                        "error": str(exc),
                    }
                )
        else:
            for request_payload, result in created:
                candidates = [item for item in flattened_devices if match_device(item, request_payload)]
                candidates = [item for item in candidates if _safe_int(item.get("id")) is not None]
                if not candidates:
                    errors.append(
                        {
                            "index": result["index"],
                            "name": result.get("name"),
                            "stage": "match_device",
                            "error": "created device was not found in device list",
                        }
                    )
                    continue
                selected = max(candidates, key=lambda item: _safe_int(item.get("id")) or 0)
                result["device_id"] = _safe_int(selected.get("id"))
                result["matched_device"] = selected

    matched = sum(1 for item in results if item.get("device_id") is not None)
    return {
        "state": 0 if not errors else 1,
        "summary": {
            "total": len(devices),
            "created": len(created),
            "matched": matched,
            "failed": len(errors),
        },
        "results": results,
        "errors": errors,
    }


def _create_points_batch(
    project_key: str,
    points: list[dict[str, Any]],
    *,
    create_path: str,
    build_payload: Any,
) -> dict[str, Any]:
    results: list[dict[str, Any]] = []
    errors: list[dict[str, Any]] = []

    for index, item in enumerate(points):
        if not isinstance(item, dict):
            errors.append({"index": index, "stage": "create_point", "error": "point item must be an object"})
            continue

        result: dict[str, Any] = {
            "index": index,
            "name": item.get("name"),
            "device_id": item.get("device_id"),
            "response": None,
        }
        results.append(result)

        try:
            request_payload = build_payload(item)
            response = _request_collector(project_key, "POST", create_path, json_payload=request_payload)
        except Exception as exc:
            errors.append({"index": index, "name": item.get("name"), "stage": "create_point", "error": str(exc)})
            continue

        result["response"] = response
        if not _success_response(response):
            errors.append(
                {
                    "index": index,
                    "name": item.get("name"),
                    "stage": "create_point",
                    "error": response.get("state_info") or response.get("msg") or str(response),
                }
            )

    success = sum(1 for item in results if isinstance(item.get("response"), dict) and _success_response(item["response"]))
    return {
        "state": 0 if not errors else 1,
        "summary": {
            "total": len(points),
            "success": success,
            "failed": len(errors),
        },
        "results": results,
        "errors": errors,
    }


def _flatten_device_tree(items: list[Any]) -> list[dict[str, Any]]:
    flattened: list[dict[str, Any]] = []
    for item in items:
        if not isinstance(item, dict):
            continue
        flattened.append(item)
        groups = item.get("groups", [])
        if isinstance(groups, list):
            flattened.extend(_flatten_device_tree(groups))
    return flattened


def _match_modbus_device(device: dict[str, Any], expected: dict[str, Any]) -> bool:
    if device.get("type") != "modbus":
        return False
    if not _same_text(device.get("name"), expected.get("name")):
        return False
    if not _same_int(device.get("device_type"), expected.get("device_type")):
        return False
    if not _same_int(device.get("slave_id"), expected.get("slave_id")):
        return False
    if not _same_int(device.get("group_id"), expected.get("group_id")):
        return False
    if not _same_int(device.get("address_offset"), expected.get("address_offset")):
        return False

    if _safe_int(expected.get("device_type")) == 2:
        return _same_text(device.get("serial_port"), expected.get("serial_port"))
    return _same_text(device.get("ip"), expected.get("ip")) and _same_int(device.get("port"), expected.get("port"))


def _match_s7_device(device: dict[str, Any], expected: dict[str, Any]) -> bool:
    if device.get("type") != "s7":
        return False
    actual_group_id = device.get("device_group_id", device.get("group_id"))
    return (
        _same_text(device.get("name"), expected.get("name"))
        and _same_text(device.get("ip"), expected.get("ip"))
        and _same_int(device.get("port"), expected.get("port"))
        and _same_int(device.get("rock"), expected.get("rock"))
        and _same_int(device.get("slot"), expected.get("slot"))
        and _same_int(device.get("device_type"), expected.get("device_type"))
        and _same_text(device.get("tsap_conn_type"), expected.get("tsap_conn_type"))
        and _same_int(actual_group_id, expected.get("device_group_id"))
    )


def _match_bacnet_device(device: dict[str, Any], expected: dict[str, Any]) -> bool:
    if device.get("type") != "bacnet":
        return False
    actual_group_id = device.get("group_id", device.get("device_group_id"))
    return (
        _same_text(device.get("name"), expected.get("name"))
        and _same_text(device.get("ip"), expected.get("ip"))
        and _same_int(device.get("port"), expected.get("port"))
        and _same_int(device.get("device_type"), expected.get("device_type"))
        and _same_int(device.get("bacnet_device_id"), expected.get("bacnet_device_id"))
        and _same_int(device.get("bacnet_net"), expected.get("bacnet_net"))
        and _same_int(actual_group_id, expected.get("group_id"))
    )


def _same_text(left: Any, right: Any) -> bool:
    return str(left or "").strip() == str(right or "").strip()


def _same_int(left: Any, right: Any) -> bool:
    normalized_left = _safe_int(left)
    normalized_right = _safe_int(right)
    return normalized_left is not None and normalized_left == normalized_right


def _safe_int(value: Any) -> int | None:
    try:
        return int(value)
    except Exception:
        return None


def edit_modbus_device(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/modbus/device/edit",
        json_payload=_merge_defaults(
            {
                "timeout": 3,
                "is_persistent": True,
                "device_group_id": 0,
                "alarm_interval": 90,
                "collect_interval": 5,
                "address_offset": 0,
                "retry_times": 0,
                "mode": 0,
            },
            _normalize_modbus_device_edit_payload(payload),
        ),
    )


def edit_modbus_point(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/modbus/point/edit_collect_point",
        json_payload=_merge_defaults(
            MODBUS_SPEC.point_defaults,
            _normalize_modbus_point_edit_payload(payload),
        ),
    )


def edit_s7_device(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/s7/device/update",
        json_payload=_merge_defaults(
            S7_SPEC.device_defaults,
            _normalize_s7_device_edit_payload(payload),
        ),
    )


def edit_s7_point(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/s7/point/update",
        json_payload=_merge_defaults(
            S7_SPEC.point_defaults,
            _normalize_s7_point_edit_payload(payload),
        ),
    )


def edit_bacnet_device(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/bacnet/device/edit",
        json_payload=_merge_defaults(
            {
                "type": 1,
                "port": 47808,
                "net": 0,
                "asp_ip": "",
                "timeout": 3,
                "is_persistent": False,
                "device_group_id": 0,
                "alarm_interval": 90,
                "collect_interval": 5,
            },
            _normalize_bacnet_device_edit_payload(payload),
        ),
    )


def edit_bacnet_point(project_key: str, payload: dict[str, Any]) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/bacnet/point/edit",
        json_payload=_normalize_bacnet_point_edit_payload(payload),
    )


def list_devices(project_key: str, num_points: bool = False) -> dict[str, Any]:
    num_points_text = "true" if num_points else "false"
    return _request_collector(
        project_key,
        "GET",
        f"/api/collector/device?num_points={num_points_text}",
    )


def connect_device(project_key: str, device_id: int, device_type: str = "modbus") -> dict[str, Any]:
    return _set_device_connect_status(
        project_key,
        device_id=device_id,
        device_type=device_type,
        status=2,
    )


def disconnect_device(project_key: str, device_id: int, device_type: str = "modbus") -> dict[str, Any]:
    return _set_device_connect_status(
        project_key,
        device_id=device_id,
        device_type=device_type,
        status=1,
    )


def list_device_points(
    project_key: str,
    device_id: int,
    device_type: str = "modbus",
    group_id: int = 0,
) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/common/device/get_collect_point",
        json_payload={
            "id": _normalize_positive_int(device_id, "device_id"),
            "type": _normalize_device_type(device_type),
            "group_id": _normalize_non_negative_int(group_id, "group_id"),
        },
    )


def _set_device_connect_status(
    project_key: str,
    *,
    device_id: int,
    device_type: str,
    status: int,
) -> dict[str, Any]:
    return _request_collector(
        project_key,
        "POST",
        "/api/collector/common/device/set_connect_status",
        json_payload={
            "id": _normalize_positive_int(device_id, "device_id"),
            "type": _normalize_device_type(device_type),
            "status": status,
        },
    )


def _normalize_device_type(device_type: str) -> str:
    normalized = str(device_type or "").strip()
    if not normalized:
        raise ValueError("device_type is required")
    return normalized


def _normalize_s7_tsap_conn_type(value: Any) -> str:
    normalized = str(value or "").strip().upper()
    if normalized not in {"PG", "OP", "BASIC"}:
        raise ValueError("payload.tsap_conn_type must be one of PG, OP, BASIC")
    return normalized


def _normalize_positive_int(value: int, field_name: str) -> int:
    try:
        normalized = int(value)
    except Exception as exc:
        raise ValueError(f"{field_name} must be a positive integer") from exc
    if normalized <= 0:
        raise ValueError(f"{field_name} must be a positive integer")
    return normalized


def _normalize_non_negative_int(value: int, field_name: str) -> int:
    try:
        normalized = int(value)
    except Exception as exc:
        raise ValueError(f"{field_name} must be a non-negative integer") from exc
    if normalized < 0:
        raise ValueError(f"{field_name} must be a non-negative integer")
    return normalized


def _normalize_bacnet_id(value: Any, field_name: str) -> int:
    normalized = _normalize_non_negative_int(value, field_name)
    if normalized > BACNET_OBJECT_ID_MAX:
        raise ValueError(f"{field_name} must be between 0 and {BACNET_OBJECT_ID_MAX}")
    return normalized